| Summary: | ASTERISK-00767: [patch] Play a tone seconds before absolutetimeout | ||
| Reporter: | nicolasg (nicolasg) | Labels: | |
| Date Opened: | 2004-01-09 12:52:40.000-0600 | Date Closed: | 2011-06-07 14:05:12 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) channel.c.2.diff ( 1) channel.c.diff | |
| Description: | This patch plays a double beep at 40,30,20 and 10 seconds before AbsoluteTimeout hangs up the call. Its an ugly hack, but it seems to work. Its not configurable, it uses chan->rings as a state variable... it's awful, and it might break other things. Not to be added to CVS in any way! ****** ADDITIONAL INFORMATION ****** For demonstration purposes only; not to be added to CVS without extensive modification! | ||
| Comments: | By: zoa (zoa) 2004-01-09 14:18:35.000-0600 nicolas, if you submit a patch, please add [patch] in front of the subject, that way its easier to browse and catalog patches for the buglist maintainers :) By: jerjer (jerjer) 2004-01-14 00:01:50.000-0600 For this to even have a chance of getting in you need two things. 1) Sign and submit a disclaimer 2) Make all comments in english By: nicolasg (nicolasg) 2004-01-14 12:11:52.000-0600 Brian: Thanks for adding [patch] to the summary. My mistake. JerJer: I sent the disclaimer the same day I sent the patch. The second attachment channel.c.2.diff is the same as the original, without the spanish log lines. I don't know if I want this patch submited. Is for demonstration only. I think that we have to make it an option or parameter in AbsoluteTimeout, instead of being hardcoded. And I'm sure that its wrong to use chan->rings as a state variable to this function. I posted this patch because its an often requested feature, and in hope of being reviewed/modified/corrected by others. By: paradise (paradise) 2004-01-25 08:14:05.000-0600 nicolas, I've already applied the patch but it doesn't function...nothing happens...The Playing Tone message wouldn't be displayed... i've tested it with sip calls. By: nicolasg (nicolasg) 2004-02-14 19:55:12.000-0600 Hi paradise, I tested the patch with the latest CVS and it works ok. Maybe you are confused about the two files in here. I dont know how to delete the first patch, maybe if you applied both, the second was detected as a reverse and simply deleted the changes. It works for me, I do not know any other person that uses it, so I can only speak for myself. It plays a tone (only to the caller) before the absolutetimeout occurs. If you apply only the first patch, you can also see log lines in the console (the second patch is the same as the first without the log lines). By: Brian West (bkw918) 2004-04-18 00:41:59 Their is a new dial patch to even play a file... this one is closed. bkw | ||