[Home]

Summary:ASTERISK-00749: permit/deny not parsing mask
Reporter:Olle Johansson (oej)Labels:
Date Opened:2004-01-06 15:24:20.000-0600Date Closed:2009-10-19 12:37:14
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/Configuration
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Permit=<ipaddr>/<mask> is not parsed correctly in IAX or SIp channels (I have not tried other channels). Only IP address is parsed. Possibly error in config.c, but I can't locate it.

****** ADDITIONAL INFORMATION ******

Added this to chan_sip.c:
 } else if (!strcasecmp(v->name, "permit") ||
                                          !strcasecmp(v->name, "deny")) {
                               peer->ha = ast_append_ha(v->name, v->value, peer->ha);
                               ast_log(LOG_DEBUG,"Peer %s has restrictions: %s = %s (installed) \n", peer->name, v->name, v->
value); /* DEBUG */

---
Output only gives IP address in value, everything from "/mask" is stripped away. acl.c only looks for '/', so there's no alternative syntax.
Comments:By: Olle Johansson (oej) 2004-01-09 12:40:12.000-0600

Even if I patch acl.c to parse correctly (accept , as delimiter) I can't get permit/deny to work at all. Other users have confirmed this.
By: Brian West (bkw918) 2004-01-10 16:32:37.000-0600

Ok we have worked on this.  In addition to a few small issues we added the ability to permit or deny using CIDR notation.  For information on this you can visit.

http://infocenter.guardiandigital.com/manuals/IDDS/node9.html

Thanks,
bkw
By: Brian West (bkw918) 2004-01-10 16:33:01.000-0600

also 0.0.0.0/0 = 0.0.0.0/0.0.0.0 on that side note.

bkw
By: Brian West (bkw918) 2004-01-10 16:36:54.000-0600

Fixed in CVS.