[Home]

Summary:ASTERISK-00657: [patch] Reinvites are not treated as new transactions
Reporter:checimovic (checimovic)Labels:
Date Opened:2003-12-11 18:46:12.000-0600Date Closed:2011-06-07 14:10:08
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_sip.txt
Description:According to RFC 3261, reinvites are new transactions, so the branch number should change. The branch is the last field in the Via header. Currently, this number doesn't change from the first invite to subsequent reinvites. This prevents certain phones, such as the Polycom phones, from natively bridging, since they track transactions with the branch number. Luckily, in Asterisk the fix for this is extremely simple: increment the branch number and rebuild the Via header when doing a reinvite.
Comments:By: Brian West (bkw918) 2003-12-14 11:32:59.000-0600

Please attach a diff -u
By: checimovic (checimovic) 2003-12-15 16:28:08.000-0600

Uploaded the correct patch file this time - chan_sip_c_fix. Sorry about that.
By: Brian West (bkw918) 2004-01-10 21:18:12.000-0600

I think this has been fixed... please confirm.
By: muckl (muckl) 2004-01-10 22:34:08.000-0600

Tested. It didnt break any of the following:
*Confecencing
*Transfer
*Hold
*Musiconhold
*Reconnect
By: checimovic (checimovic) 2004-01-12 15:49:19.000-0600

Hi Brian, when you say "fixed", do you mean fixed in CVS without the patch being applied? As of today's (Jan. 12, 2004) CVS, this issue is not fixed. Polycom phones do not bridge. I reapplied the patch, and lo and behold, they bridge natively (that is, the SIP reinvite works).
By: Brian West (bkw918) 2004-01-12 20:08:41.000-0600

Have you sent in a disclaimer?
By: Digium Subversion (svnbot) 2008-01-15 14:41:10.000-0600

Repository: asterisk
Revision: 2000

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r2000 | jeremy | 2008-01-15 14:41:10 -0600 (Tue, 15 Jan 2008) | 2 lines

via z9hG4bK issue. Bug ASTERISK-657

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=2000