Summary:	ASTERISK-00597: [patch] Add caller ID reporting to voicemail system
Reporter:	hwstar (hwstar)	Labels:
Date Opened:	2003-11-29 21:09:39.000-0600	Date Closed:	2011-06-07 14:05:00
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk-callerid-in-voicemail-0.0.1.patch.tar.gz ( 1) asterisk-callerid-in-voicemail-0.0.2.patch.tar.gz
Description:	The attached patch reads back the caller ID of the person who left a voice mail message. Files changed: app_voicemail.c Files added: vm_from.gsm, vm_an_unknown_number.gsm. After entering voice mail and selecting a message to be played back, the user will hear the message number, and the time just like prior versions. After the time, the user will hear either 'from an unknown number', 'from extension XXXX' or 'from XXXXXXXXXXX' depending upon configuration settings in voicemail.conf, and whether caller id was present when the message was deposited.   ****** ADDITIONAL INFORMATION ****** After applying the patch, edit your voicemail.conf file and add voicemailcid=yes in the general section. This turns on the feature. If you would like outside line contexts not to be announced as extensions, add cidexternalcontexts in the general section like this: cidexternalcontexts=inbound-calls-main, screener-extensions                                                                                                                                       The contexts listed above option will be announced without the word 'extension' i.e. 'from XXXXXXXXXXX' or 'from an unknown number' The disclaimer for above code is on its way to Digium via snail mail. If the patch becomes popular, then it would be nice to have the prompts re-recorded by Allison.
Comments:	By: hex (hex) 2003-11-30 04:31:49.000-0600 Personally, I would rather make it so you have to send a DTMF digit to hear the caller id information (pause playback, say the numbers, and resume).  I used to have my cell phone voicemail set up to tell me the phone number but it added a lot of time to check my messages.  Most of the time you know who's calling by their voice but in rare instances you need to find out what the caller id was.  Even if you don't implement it this way you may want to disable saying the time when an ADSI capable phone has been detected. By: Tilghman Lesher (tilghman) 2003-11-30 08:31:04.000-0600 Instead of hardcoding the callerid into the message stream, why don't you make this configurable in the same way that datetime currently is?  Why not make callerid simply another character in the zonemessage, so that hearing callerid is configurable per user? By: tclark (tclark) 2003-11-30 09:54:56.000-0600 and while your at it allow 1 xtra dtmf to allow calling back that callerid :) By: hex (hex) 2003-11-30 10:11:28.000-0600 That is already in bug ASTERISK-153 supposedly, but I haven't tried it yet.  I should apply it since that would be a very nice feature to have.  I still like the idea of DTMFing the number playback because no one in their right mind with 20+ messages in their voicemail box wants to spend the extra 5-8 seconds listening to the number on every message. By: hwstar (hwstar) 2003-11-30 10:56:33.000-0600 hex- Yes I did notice after the fact that this feature was added to bug 156 during its testing and development. As for the case where the user as 20+ messages in their voice mail box, I can sympathize. I coded it this way because that's what I was exposed to with the Nortel system where I work. In my case I seem to have more than a few messages in my voicemail box so the extra time to hear the caller ID is tolerable. Corydon76- I like the idea of making it configurable per user. I'll investigate this further. Maybe we can merge this into the work done on bug 156. Steve. By: hwstar (hwstar) 2003-11-30 21:11:07.000-0600 I have a new patch file, (version 0.0.2) which does as Corydon76 suggested. The callerid feature can now be enabled and disabled on a per-user basis. The way it is done is like this: ; ; format: password, name, email address, pager address, options for attached ; voicemail msgs ;                                                                                                                                             101 => XXXX,Steve Rodgers,,,saycid=yes Existing options can preceed the saycid if delimited by a vertical bar. Changes from version 0.0.1 to 0.0.2: The configuration option 'voicemailcid' has been removed since it's function has now been moved to the per user level. By: Brian West (bkw918) 2004-01-27 20:08:14.000-0600 See if you can work with brad on bug 156 to unify the two patches into one... w are waiting on re-record of files on 156 to apply it. By: Brian West (bkw918) 2004-01-31 21:42:45.000-0600 Move to bug 156 to merge into one nice patch for voicemail.