[Home]

Summary:ASTERISK-00586: Missing digit sounds for 24h format (voicemail2)
Reporter:philipp2 (philipp2)Labels:
Date Opened:2003-11-27 16:06:21.000-0600Date Closed:2008-01-15 14:38:54.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20031130__say__bugfix.diff
( 1) say.diff.txt
Description:Symptom: Voicemail terminates if set to 24 hour reporting format and a message was left between 21.00 and 23.59.

Missing in /var/lib/asterisk/sounds/digits/:
21.gsm
22.gsm
23.gsm

Not sure if also these should exists:
h-21.gsm
h-22.gsm
h-23.gsm


****** ADDITIONAL INFORMATION ******

These files I have on my system:

-rwxr-xr-x    1 root     root         1452 Nov 22 22:08 0.gsm
-rwxr-xr-x    1 root     root         1023 Nov 22 22:08 10.gsm
-rwxr-xr-x    1 root     root         1617 Nov 22 22:08 11.gsm
-rwxr-xr-x    1 root     root         1683 Nov 22 22:08 12.gsm
-rwxr-xr-x    1 root     root         1782 Nov 22 22:08 13.gsm
-rwxr-xr-x    1 root     root         1881 Nov 22 22:08 14.gsm
-rwxr-xr-x    1 root     root         2013 Nov 22 22:08 15.gsm
-rwxr-xr-x    1 root     root         2178 Nov 22 22:08 16.gsm
-rwxr-xr-x    1 root     root         2244 Nov 22 22:08 17.gsm
-rwxr-xr-x    1 root     root         2046 Nov 22 22:08 18.gsm
-rwxr-xr-x    1 root     root         2244 Nov 22 22:08 19.gsm
-rwxr-xr-x    1 root     root          957 Nov 22 22:08 1.gsm
-rwxr-xr-x    1 root     root         1122 Nov 22 22:08 20.gsm
-rwxr-xr-x    1 root     root          990 Nov 22 22:08 2.gsm
-rwxr-xr-x    1 root     root          957 Nov 22 22:08 30.gsm
-rwxr-xr-x    1 root     root         1122 Nov 22 22:08 3.gsm
-rwxr-xr-x    1 root     root          990 Nov 22 22:08 40.gsm
-rwxr-xr-x    1 root     root          924 Nov 22 22:08 4.gsm
-rwxr-xr-x    1 root     root         1155 Nov 22 22:08 50.gsm
-rwxr-xr-x    1 root     root         1023 Nov 22 22:08 5.gsm
-rwxr-xr-x    1 root     root         1155 Nov 22 22:08 60.gsm
-rwxr-xr-x    1 root     root          891 Nov 22 22:08 6.gsm
-rwxr-xr-x    1 root     root         1353 Nov 22 22:08 70.gsm
-rwxr-xr-x    1 root     root         1089 Nov 22 22:08 7.gsm
-rwxr-xr-x    1 root     root         1089 Nov 22 22:08 80.gsm
-rwxr-xr-x    1 root     root          792 Nov 22 22:08 8.gsm
-rwxr-xr-x    1 root     root         1353 Nov 22 22:08 90.gsm
-rwxr-xr-x    1 root     root         1254 Nov 22 22:08 9.gsm
-rwxr-xr-x    1 root     root         1848 Nov 22 22:08 a-m.gsm
-rwxr-xr-x    1 root     root          858 Nov 22 22:08 at.gsm
-rwxr-xr-x    1 root     root         1452 Nov 22 22:08 day-0.gsm
-rwxr-xr-x    1 root     root         1980 Nov 22 22:08 day-1.gsm
-rwxr-xr-x    1 root     root         1617 Nov 22 22:08 day-2.gsm
-rwxr-xr-x    1 root     root         2013 Nov 22 22:08 day-3.gsm
-rwxr-xr-x    1 root     root         1848 Nov 22 22:08 day-4.gsm
-rwxr-xr-x    1 root     root         1716 Nov 22 22:08 day-5.gsm
-rwxr-xr-x    1 root     root         1683 Nov 22 22:08 day-6.gsm
-rwxr-xr-x    1 root     root         1353 Nov 22 22:08 dollars.gsm
-rwxr-xr-x    1 root     root          990 Nov 22 22:08 h-10.gsm
-rwxr-xr-x    1 root     root         1287 Nov 22 22:08 h-11.gsm
-rwxr-xr-x    1 root     root         1056 Nov 22 22:08 h-12.gsm
-rwxr-xr-x    1 root     root         1650 Nov 22 22:08 h-13.gsm
-rwxr-xr-x    1 root     root         1584 Nov 22 22:08 h-14.gsm
-rwxr-xr-x    1 root     root         1485 Nov 22 22:08 h-15.gsm
-rwxr-xr-x    1 root     root         1551 Nov 22 22:08 h-16.gsm
-rwxr-xr-x    1 root     root         1749 Nov 22 22:08 h-17.gsm
-rwxr-xr-x    1 root     root         1386 Nov 22 22:08 h-18.gsm
-rwxr-xr-x    1 root     root         1617 Nov 22 22:08 h-19.gsm
-rwxr-xr-x    1 root     root         1155 Nov 22 22:08 h-1.gsm
-rwxr-xr-x    1 root     root         1287 Nov 22 22:08 h-20.gsm
-rwxr-xr-x    1 root     root         1254 Nov 22 22:08 h-2.gsm
-rwxr-xr-x    1 root     root         1650 Nov 22 22:08 h-30.gsm
-rwxr-xr-x    1 root     root          957 Nov 22 22:08 h-3.gsm
-rwxr-xr-x    1 root     root         1221 Nov 22 22:08 h-4.gsm
-rwxr-xr-x    1 root     root         1023 Nov 22 22:08 h-5.gsm
-rwxr-xr-x    1 root     root         1188 Nov 22 22:08 h-6.gsm
-rwxr-xr-x    1 root     root         1254 Nov 22 22:08 h-7.gsm
-rwxr-xr-x    1 root     root         1023 Nov 22 22:08 h-8.gsm
-rwxr-xr-x    1 root     root         1089 Nov 22 22:08 h-9.gsm
-rwxr-xr-x    1 root     root         1221 Oct 22 23:16 hours.gsm
-rwxr-xr-x    1 root     root         1122 Nov 22 22:08 hundred.gsm
-rwxr-xr-x    1 root     root         1320 Nov 22 22:08 million.gsm
-rwxr-xr-x    1 root     root         1914 Nov 22 22:08 mon-0.gsm
-rwxr-xr-x    1 root     root         1815 Nov 22 22:08 mon-10.gsm
-rwxr-xr-x    1 root     root         2013 Nov 22 22:08 mon-11.gsm
-rwxr-xr-x    1 root     root         2046 Nov 22 22:08 mon-1.gsm
-rwxr-xr-x    1 root     root         1584 Nov 22 22:08 mon-2.gsm
-rwxr-xr-x    1 root     root         1386 Nov 22 22:08 mon-3.gsm
-rwxr-xr-x    1 root     root         1254 Nov 22 22:08 mon-4.gsm
-rwxr-xr-x    1 root     root         1683 Nov 22 22:08 mon-5.gsm
-rwxr-xr-x    1 root     root         1551 Nov 22 22:08 mon-6.gsm
-rwxr-xr-x    1 root     root         1353 Nov 22 22:08 mon-7.gsm
-rwxr-xr-x    1 root     root         1617 Nov 22 22:08 mon-8.gsm
-rwxr-xr-x    1 root     root         1848 Nov 22 22:08 mon-9.gsm
-rwxr-xr-x    1 root     root         1452 Nov 22 22:08 oclock.gsm
-rwxr-xr-x    1 root     root         1188 Nov 22 22:08 oh.gsm
-rwxr-xr-x    1 root     root         1485 Nov 22 22:08 p-m.gsm
-rwxr-xr-x    1 root     root         1155 Nov 22 22:08 pound.gsm
-rwxr-xr-x    1 root     root         1353 Nov 22 22:08 star.gsm
-rwxr-xr-x    1 root     root         1155 Nov 22 22:08 thousand.gsm
-rwxr-xr-x    1 root     root         1254 Nov 22 22:08 today.gsm
-rwxr-xr-x    1 root     root         1287 Nov 22 22:08 tomorrow.gsm
-rwxr-xr-x    1 root     root         1320 Nov 22 22:08 yesterday.gsm
Comments:By: Olle Johansson (oej) 2003-11-30 03:06:22.000-0600

Same here, those files seems to be missing.
By: Tilghman Lesher (tilghman) 2003-11-30 08:35:54.000-0600

Those files are not missing.  Asterisk recreates numbers as it needs them.  Therefore 21 is equivalent to saying 20.gsm followed by 1.gsm.  The same goes for ordinals.  21st is equivalent to saying 20.gsm followed by h-1.gsm.

Patch uploaded to fix this oversight in say.c

edited on: 11-30-03 08:38
By: philipp2 (philipp2) 2003-11-30 11:44:57.000-0600

Something is definitely wrong: Either the files are missing, or * goes about the wrong way to say the hour "21". Look here:

Nov 27 22:29:52 WARNING[378107]: File file.c, Line 446 (ast_openstream): File /var/lib/asterisk/sounds/digits/21 does not exist in any format
Nov 27 22:29:52 WARNING[378107]: File file.c, Line 725 (ast_streamfile): Unable to open /var/lib/asterisk/sounds/digits/21 (format ULAW): No such file or directory
Nov 27 22:29:52 WARNING[378107]: File say.c, Line 243 (wait_file): Unable to play message /var/lib/asterisk/sounds/digits/21

Added:
To be clear, this is not me doing something like Playback(digits/21) here. This happens when trying to listen to incoming voicemail that was recorded between 21.00 and 21.59 while you have set that's persons vm settings to 24-hour format through a tz=xxx value. BTW, my indications.conf is set to country=[be], however I don't think this matters here.

edited on: 11-30-03 11:40

Added:
Ok, didn't see the patch, I guess that'll fix it (didn't text yet, still gotta learn how to apply diffs) :-)

edited on: 11-30-03 12:17
By: Mark Spencer (markster) 2003-12-07 23:33:22.000-0600

Fixed in CVS
By: Digium Subversion (svnbot) 2008-01-15 14:38:54.000-0600

Repository: asterisk
Revision: 1838

U   trunk/say.c

------------------------------------------------------------------------
r1838 | markster | 2008-01-15 14:38:54 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix hours 21-23 (bug ASTERISK-586)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=1838