Summary:ASTERISK-00582: "Contact" patch from bug #580 breaks SIP hold
Reporter:lele (lele)Labels:
Date Opened:2003-11-27 08:41:25.000-0600Date Closed:2004-09-25 02:49:15
Versions:Frequency of
Environment:Attachments:( 0) chan_sip.c.diff
Description:The "Contact" patch from bug ASTERISK-476 applied in current CVS is breaking the hold capability by sending out a wrong "Contact" header in response to hold invites.

After appliying the patch any call put on hold is dropped after a few seconds.

Comments:By: exomorph (exomorph) 2003-11-27 13:19:01.000-0600

Kram applied a patch that set things back to the way they were, this patch I just sent fixes this properly by only copying the contact feild if our_contact isn't set.

By: exomorph (exomorph) 2003-11-27 13:21:18.000-0600

BTW, Kram...  I tried doing things your way, but it produces a contact field like:

Contact: <sip:@>

Where is should be:

Contact: <sip:jondesk@>

This is why we have to copy it instead of building it.

By: Brian West (bkw918) 2003-11-27 22:35:43.000-0600

Fixed in CVS