Summary:ASTERISK-00576: [patch] allows FLASH button to hangup if not in 3-way call or conference
Reporter:cmaj (cmaj)Labels:
Date Opened:2003-11-26 11:38:46.000-0600Date Closed:2011-06-07 14:05:32
Versions:Frequency of
Environment:Attachments:( 0) flash_not_in_3way_hangsup_20040127.patch
( 1) flash_not_in_3way_hangsup.patch
Description:This functionality matches that of what one would expect from a normal residential phone, ie. one that doesn't allow 3-way calling or conference calling.  The flash button should simply hangup the phone.


This patch affects an area of code marked with porn XXX's, so it looked ripe for fixing. :)
Comments:By: cmaj (cmaj) 2003-11-26 11:39:34.000-0600

Note this is in the Zaptel section because the only affected file is chan_zap.c

By: jrollyson (jrollyson) 2003-11-28 23:42:22.000-0600

This should be configurable imho - should be able to either hangup, ignore, or (for future expandability) interpet flash as a command to start/stop reading digits from a zap channel.

By: cmaj (cmaj) 2003-12-03 18:21:29.000-0600

I disagree.  This patch re-creates standard behavior of an analog phone.  Any fancy flash work should be in a separate patch.

By: Brian West (bkw918) 2004-01-26 23:26:35.000-0600

has this been disclaimed and is it updated to patch against latest CVS.

By: cmaj (cmaj) 2004-01-27 13:43:22.000-0600

Yes, this is disclaimed -- I've had other patches applied.  I just updated it to work with current CVS.  Patch works on my production system, on phone lines set callwaiting=no and threewaycalling=no; and it also works on lines set with callwaiting=yes and threewaycalling=no; but I have not tested with callwaiting=yes and threewaycalling=yes because to be honest I could never figure that out :P

By: Brian West (bkw918) 2004-04-18 01:31:22

This totally isn't what's expected when making a phone call and using flash.  My flash key when using my pots line doesn't hangup the call.  And we don't need to change the standard way of doing things without a config option to toggle that on and off!

Can you get a patch to allow a config option and up date the patch for CVS-HEAD.