[Home]

Summary:ASTERISK-00496: [patch] memory leak in cli
Reporter:izo (izo)Labels:
Date Opened:2003-11-06 21:01:57.000-0600Date Closed:2004-09-25 02:55:01
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) asterisk.c_patch
( 1) cli.c_patch
Description:Using auto comple function from cli results in mem leak.
Patch attached.

ps.
patch has non-unix ;-) nl chars
Comments:By: izo (izo) 2003-11-06 21:02:40.000-0600

Will there be any bonus for ASTERISK-496 bug report ;-)
By: izo (izo) 2003-11-07 09:05:18.000-0600

WARNING: It fixes memmory leak for asterisk console
but when used with remote console asterisk -vvvr segfaults.
Dont apply.
By: Mark Spencer (markster) 2003-11-09 13:07:31.000-0600

Added to CVS
By: izo (izo) 2003-11-09 13:58:38.000-0600

Need to add in asterisk.cli
if (option_remote) {
// when freeing
for (x=0; matches[x]; x++) {
  free(matches[x]);
  matches[x] = NULL;
}
}
otherwise it segfaults when using tab completion from asterisk cli
By: Brian West (bkw918) 2003-11-22 14:09:08.000-0600

izo has this been added?  I don't see the tab completion issue with current CVS.
By: izo (izo) 2003-11-22 20:33:27.000-0600

It hasn't been added yet. I just uploaded two patches for cli.c and asterisk.c that should fix memleak problem in cli and dont cause segfaults anymore.
By: Brian West (bkw918) 2003-11-22 20:44:05.000-0600

so the 11/6 patch needs to be removed?
By: izo (izo) 2003-11-23 06:54:11.000-0600

Well, yes but I dont know how to do it
By: zoa (zoa) 2004-01-09 19:51:49.000-0600

is this already in cvs or not ?

BKW, what does valgrind say about this ? do we still need this patch ?
By: jrollyson (jrollyson) 2004-01-14 03:50:46.000-0600

Believed to be fixed in CVS, resubmit with updated patch if you discover otherwise.