| Summary: | ASTERISK-00494: [patch] ast_callerid_parse() typo | ||
| Reporter: | Paul Cadach (pcadach) | Labels: | |
| Date Opened: | 2003-11-06 12:10:21.000-0600 | Date Closed: | 2011-06-07 14:04:51 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) asterisk-0.5.0-cidform.diff | |
| Description: | Typo mistake - must be (*name)++ instead of name++: while(**name && (**name < 33)) name++; ****** ADDITIONAL INFORMATION ****** Included patch uses local variables rather than to de-reference *name to access to symbols and checks phone number validity before treat it as location argument value. Also, check XXX comment!!! | ||
| Comments: | By: Mark Spencer (markster) 2003-11-09 12:21:03.000-0600 I fixed the typo, but not all locations are necessarily a phone number. They could potentially be something liek a URL right? By: Paul Cadach (pcadach) 2003-11-09 12:53:09.000-0600 Ok, but what about de-referencing *name instead of using existing local variables and minimize usage of strlen() in space stripping loops? | ||