[Home]

Summary:ASTERISK-00492: Makefile doesn't do uname -m on FreeBSD
Reporter:matthewa (matthewa)Labels:
Date Opened:2003-11-13 17:23:54.000-0600Date Closed:2004-09-25 02:49:15
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Top level Makefile doesn't do uname -m causing failed compile of gsm codec under FreeBSD.

****** ADDITIONAL INFORMATION ******

compile:
...
gmake -C gsm lib/libgsm.a
gmake[2]: Entering directory `/usr/home/matthewa/as/asterisk/codecs/gsm'
if [ ! -d ./lib ] ; then mkdir ./lib ; fi
gcc -O6 -march= -fomit-frame-pointer   -c -DNeedFunctionPrototypes=1 -funroll-lo
ops -fPIC -DSASR -DNDEBUG    -DWAV49   -I./inc src/add.c
cc1: bad value () for -march= switch
gmake[2]: *** [src/add.o] Error 1
gmake[2]: Leaving directory `/usr/home/matthewa/as/asterisk/codecs/gsm'
gmake[1]: *** [gsm/lib/libgsm.a] Error 2
gmake[1]: Leaving directory `/usr/home/matthewa/as/asterisk/codecs'

fix:

*** Makefile~   Wed Nov 12 17:47:23 2003
--- Makefile    Thu Nov 13 15:12:24 2003
***************
*** 20,25 ****
--- 20,29 ----

 ifeq (${OSARCH},Linux)
 PROC=$(shell uname -m)
+ else
+  ifeq (${OSARCH},FreeBSD)
+   PROC=$(shell uname -m)
+  endif
 endif
 # Pentium Pro Optimize
 #PROC=i686


i suspect uname -m will work on most platforms, is it necessary to wrap the uname call in an ifeq at all?

Comments:By: Brian West (bkw918) 2003-11-13 18:01:42.000-0600

Can you attach a diff -u of this?  

Thanks,
bkw
By: Mark Spencer (markster) 2003-11-13 18:02:36.000-0600

Fixed in CVS.  In the future, please attach your patches rather than putting them as a comment.