[Home]

Summary:ASTERISK-00483: [patch] When tranfering call to park or other extension, person you transfer gets prompt if you type in invalid extension
Reporter:connor (connor)Labels:
Date Opened:2003-11-05 10:27:43.000-0600Date Closed:2011-06-07 14:10:11
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) res_parking.patch.txt
Description:When tranfering call to park or other extension, person you transfer gets prompt if you type in invalid extension.  Joe Blow calls me, I hit # 701 (My park ext is 700, is just "miss typed it") Joe gets, the, that's a invalid extension prompt and I get dumped.
Comments:By: tclark (tclark) 2003-11-05 11:20:06.000-0600

The issue looks like res.parking.c line 348 calls
ast_exists_extension

and since 701 is a valid extension, ast_exists_extension returns true
the transfer is then attempted but because
no one is actually parked on that extension, the transferred party hears the
'pbx-invalidpark' message....


Not sure of the right solution maybe ast_exists_extension should return false
if the extension is a parking extension BUT no one is actually parked on that extension... maybe we need action for pbx.c->pbx_extension_helper
specfic to transfers that reurn false for parking exts that have no one parked..

or maybe just a local change to res_parking.c to check if ext is valid per
ast_matchmore_extension then check if ext is a parking ext with a call park , then just pass on the transfer
comments ??

OK i did the local chg to res parking

Note php is puking when i tried to upload this patch
APPLICATION ERROR ASTERISK-11: ERROR: File upload failed. PHP file uploads may be disabled. Please ask your admin to run the admin_check script to debug this problem.
(bug_file_add.php: line 33)

edited on: 11-12-03 17:36
By: Brian West (bkw918) 2003-11-12 22:46:12.000-0600

can you attach the diff?
By: tclark (tclark) 2003-11-13 10:07:44.000-0600

Note php is puking when i tried to upload this patch
APPLICATION ERROR 0000015: ERROR: File upload failed. PHP file uploads may be disabled. Please ask your admin to run the admin_check script to debug this problem.
(bug_file_add.php: line 33)
By: Brian West (bkw918) 2003-11-13 12:09:05.000-0600

seems to fix it.

res_parking.c:105: warning: no previous prototype for `exists_parkedcall'

but is that normal?
By: Malcolm Davenport (mdavenport) 2003-11-13 13:39:03.000-0600

Can you try that upload patch again?  I uploaded test.txt and it seemed to go fine.
By: Brian West (bkw918) 2003-11-23 17:25:05.000-0600

This isn't a bug at all.  Its working as designed but not as a user would expect.  The attached patch might breaks something thats not well documented.

Step 1.  Park inbound call.
Step 2.  Transfer second inbound call to the parking extension from Step 1.
Step 3.  Calls are connected.

That function might be broken if the attached patch is applied.

The one sure way to fix this is to dynamically allocate the parking lot.  Build and Destroy the parking slots when they are needed.  Can anyone else confirm/deny the attached patch breaks the above mentioned function?

tclark can you double check your patch?
By: tclark (tclark) 2003-11-28 00:52:10.000-0600

ok quick chg here made new funcs local no need to add to res_parking.h

this functionaly is ok
Step 1. Park inbound call.
Step 2. Transfer second inbound call to the parking extension from Step 1.
Step 3. Calls are connected

ther is still sumfin screwed with the permissions here
APPLICATION ERROR ASTERISK-11: ERROR: File upload failed. PHP file uploads may be disabled. Please ask your admin to run the admin_check script to debug this problem.
(bug_file_add.php: line 33)
mail to bkw
By: Brian West (bkw918) 2003-11-29 13:46:37.000-0600

new patch attached.
By: Tilghman Lesher (tilghman) 2003-11-30 09:09:13.000-0600

bkw, what you were describing as an undocumented feature sounds like a bug to me.  I don't think there's any situation where you would want two incoming callers to be connected inadvertently.  If you do want them connected, then start a 3-way call with the two incoming parties, then hangup the office phone (and the remaining two callers stay connected).
By: sbingner (sbingner) 2003-12-14 15:48:08.000-0600

Suggestion: when using # transfers, make an option to playback extension dialed, then transfer if # is pressed again or cancel if * is pressed.  Eg:

1. Call is connected
2. Local user presses ASTERISK-695
3. PBX says "seven-zero-one"
4. User presses * to cancel or # to actually connect call

This of course should be configurable, but even without the prompt, I think it should be ASTERISK-694# so that if you have a typo and realize it... you can cancel by dialing ASTERISK-695*
By: Olle Johansson (oej) 2004-03-22 11:28:49.000-0600

There seems to be no movement behind this patch. If it's still needed, we'll reopen it. /Olle
By: connor (connor) 2004-05-29 20:22:28

Bug still exists in latest CVS.  Patch never made it into CVS. Can someone look over patch and make sure it works?
By: Brian West (bkw918) 2004-05-31 15:17:51

its not a bug. Its how it was designed to work.
By: connor (connor) 2004-05-31 16:26:03

If it's designed to work this way, then it needs to be re-designed.  NO WAY IN HELL should anyone other than the person doing the park EVER get a prompt..

It's simple, If I transfer someone to a invalid extension, I should get the prompt, not the person I'm trying to transfer, and I shouldn't get disconnected from the call..
By: Olle Johansson (oej) 2004-06-13 15:49:04

Does this patch apply to current cvs head?

We also need more people that backs this change up.
By: Brian West (bkw918) 2004-06-17 13:57:23

use valetparking if you can find it.. its configurable and doesn't suffer this issue.  This is not a bug its working like it should.  The only way to fix it is to prefix the callpickup slots with a *  then it won't happen.
By: Brian West (bkw918) 2004-07-01 22:52:48

This is not a bug... it functions as designed.  Move your parking slots away from your parkext