[Home]

Summary:ASTERISK-00473: [patch] Passing g723.1 packets can result in infinite loop
Reporter:bleckey (bleckey)Labels:
Date Opened:2003-11-02 14:35:02.000-0600Date Closed:2008-01-15 14:36:49.000-0600
Priority:BlockerRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) rtp.c.diff
Description:I've found, when passing g723.1 that occasionally the rtp thread will loop forever.

It turns out that the problem is in rtp.c.  If g723_len returns 0, then g723_samples will never update pos, its offset variable, and will forever check the same position in the buffer.

This patch fixes that.
Comments:By: Brian West (bkw918) 2003-11-02 16:23:51.000-0600

I was playing with g723 pass thru on some ATA"s and wondered why it did this.. I will test this and see if that fixees it.

bkw

By: Brian West (bkw918) 2003-11-02 16:37:43.000-0600

Yes that seems to fix the problem. :) w00t

By: jerjer (jerjer) 2003-11-03 00:48:14.000-0600

commited and tested, works.

By: Digium Subversion (svnbot) 2008-01-15 14:36:49.000-0600

Repository: asterisk
Revision: 1685

U   trunk/rtp.c

------------------------------------------------------------------------
r1685 | jeremy | 2008-01-15 14:36:49 -0600 (Tue, 15 Jan 2008) | 2 lines

fix g.723.1 pass-thru. Bug ASTERISK-473

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=1685