|Summary:||ASTERISK-00446: [patch] If mpg123 is mpg321, refuse to load MusicOnHold|
|Reporter:||Tilghman Lesher (tilghman)||Labels:|
|Date Opened:||2003-10-28 11:35:28.000-0600||Date Closed:||2004-09-25 02:24:30|
|Environment:||Attachments:||( 0) res_musiconhold__fix_mpg321__20031028.diff|
|Description:||Fairly frequently, people complain that MusicOnHold doesn't work, when in fact, they have mpg321 installed and symlinked to mpg123. This patch checks the binary to make sure that it is really mpg123 and not something else.|
|Comments:||By: Jared Smith (jsmith) 2003-10-28 12:50:10.000-0600|
I vote for this to be included in CVS... it would cut down tremendously on the "MOH doesn't work" email on the mailing list...
By: John Todd (jtodd) 2003-10-28 23:36:48.000-0600
By: Mark Spencer (markster) 2003-11-04 23:24:47.000-0600
This is a bug in mpg321 because it grabs the option and ignores it. Although the workaround is clever (messy, subject to symlink in /tmp attacks, etc, but still clever), the right solution is to get mpg321 to support it properly.