[Home]

Summary:ASTERISK-00440: cdr_pgsql.c needs more debugging output
Reporter:florian (florian)Labels:
Date Opened:2003-10-28 03:40:30.000-0600Date Closed:2011-06-07 14:04:46
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:I've added a small modification to cdr_pgsql.c after noticing missing some cdr's in the database. The ERROR output is too brief/nondescript.

I am not sure what the best way to diff a patch with cvs, so I just added the info below.

****** ADDITIONAL INFORMATION ******

vectra:/usr/src/cvs/asterisk/cdr# cvs diff cdr_pgsql.c
Index: cdr_pgsql.c
===================================================================
RCS file: /usr/cvsroot/asterisk/cdr/cdr_pgsql.c,v
retrieving revision 1.2
diff -r1.2 cdr_pgsql.c
80c80
<                       ast_log(LOG_ERROR, "cdr_pgsql: connection was lost... reattempting connection.");
---
>                       ast_log(LOG_ERROR, "cdr_pgsql: connection was lost... reattempting connection.\n");
83c83
<                               ast_log(LOG_ERROR, "cdr_pgsql: connection reestablished.");
---
>                               ast_log(LOG_ERROR, "cdr_pgsql: connection reestablished.\n");
86c86
<                               ast_log(LOG_ERROR, "cdr_pgsql: unable to reconnect to database.");
---
>                               ast_log(LOG_ERROR, "cdr_pgsql: unable to reconnect to database.\n");
127c127,128
<                       ast_log(LOG_ERROR,"cdr_pgsql: Failed to insert call detail record into database.");
---
>                       ast_log(LOG_ERROR,"cdr_pgsql: Failed to insert call detail record into database (%s).\n",PQerrorMessage(conn));
>
Comments:By: florian (florian) 2003-10-28 03:41:38.000-0600

Oh, as you can see I also added some \n's to lines that didn't have them, it makes the log more readable.
By: Brian West (bkw918) 2003-10-28 10:47:29.000-0600

diff -u old new or is it new old... but thats now you do it. :P  Also check bug 442 see if you can add CDR UserField support :)
By: Ben Klang (bklang) 2003-11-05 09:44:37.000-0600

this has been resolved with mantis bug number 481, in cdr_pgsql.c version 1.3.  I saw it merged into CVS last night.