| Summary: | ASTERISK-00439: [patch] Added User fields to the CDR | ||
| Reporter: | jjhuff (jjhuff) | Labels: | |
| Date Opened: | 2003-10-27 18:42:13.000-0600 | Date Closed: | 2004-09-25 02:52:04 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) cdr_user_fields.diff | |
| Description: | This patch adds a new app (SetCDRUserField) and support for additional fields in the CDR code. This allows the dialplan/AGI to add whatever additional info it needs to. I added backend support to the CSV driver only so far. The PG drive is pending me setting up a PG server. bkw_ is currently testing... | ||
| Comments: | By: Brian West (bkw918) 2003-10-27 18:47:13.000-0600 Works for me.. By: Brian West (bkw918) 2003-10-28 19:20:48.000-0600 Need to add a /* #define CSV_LOGUSERFIELDS 1 */ #ifdef CSV_LOGUSERFIELDS #endif Similar to the uniqueid stuff someone said that broke other people's CDR records. By: John Todd (jtodd) 2003-10-28 23:35:55.000-0600 Brian: so where does that patch appear? Can we get a "final" version of the patch? Should this wait until the postgres path appears before Mark spends time integrating into mainline CVS? Side note: this is a good addition, in my opinion. By: jjhuff (jjhuff) 2003-10-29 15:56:54.000-0600 I attached a new version of the patch after talking with Mark. This added the #ifdefs so it won't break people's CDRs. Actually, I just realized that I enabled it by defalt. I'll fix that and repost the patch. This also reduces the number of fields to 1. The SetCDRUserField now only takes the data. I also added AppendCDRUserField. By: John Todd (jtodd) 2003-10-29 17:56:10.000-0600 So, I'm not clear on your last note. Originally, there were N possible user-defined fields. Now it's just 1? That's not what I see in the latest patch... By: jjhuff (jjhuff) 2003-10-29 18:01:17.000-0600 The latest (10/29 15:57) only has 1. I just looked, and it seems to be correct. By: Brian West (bkw918) 2003-10-29 18:10:55.000-0600 works with the 1 field. jtodd it was N possible user fields .. I think he lowered it down due to memory concerns. Not totally sure.. I also think he is working on cdr.conf so we can turn these on and off like a switch. By: John Todd (jtodd) 2003-10-29 18:19:29.000-0600 OK, my mis-understanding due to a bad broswer file naming issue (looking at wrong file) - this seems to be as described. By: Brian West (bkw918) 2003-10-31 10:48:58.000-0600 lets get it into cvs?!? By: jerjer (jerjer) 2003-11-05 00:48:21.000-0600 I have implemented these features locally. Works as expected. By: Brian West (bkw918) 2003-11-21 10:37:32.000-0600 Ready for CVS By: zoa (zoa) 2004-01-09 19:40:36.000-0600 can this be added into cvs ? (Bkw, do you have cvs privileges as #1 bugtracker ? :) By: Brian West (bkw918) 2004-01-10 21:41:05.000-0600 Added to CVS | ||