[Home]

Summary:ASTERISK-00432: [patch] SendDTMF lacks error handling, undocumented
Reporter:Olle Johansson (oej)Labels:
Date Opened:2003-10-26 15:35:41.000-0600Date Closed:2008-01-15 14:48:44.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) appdtmf.txt
Description:App senddtmf seems to accept any string without an error message. Also, "show application senddtmf" does not document very well what you can send or not.

"Digits" should propably be [0-9*#]

****** ADDITIONAL INFORMATION ******

Example:

exten => 2200,2,senddtmf(Blåbär)

---
Executing SendDTMF("SIP/oej-7a09", "Blåbär") in new stack
   -- Sent digit string 'Blåbär' on SIP/oej-7a09
---
 -= Info about application 'SendDTMF' =-

[Synopsis]:
 Sends arbitrary DTMF digits

[Description]:
 SendDTMF(digits): Sends DTMF digits on a channel.  Returns 0 on successor -1 on a hangup.

Comments:By: Brian West (bkw918) 2003-12-06 11:57:34.000-0600

Can you attach a diff -u for these changes?
By: Olle Johansson (oej) 2003-12-06 15:01:32.000-0600

Is 0-9 , * and # correct DTMF supported characters?
By: Olle Johansson (oej) 2003-12-06 15:14:08.000-0600

Ok, patch limits DTMF to 0-9,*,#

If this is wrong, tell me now... :-)
By: Olle Johansson (oej) 2003-12-06 15:21:59.000-0600

Added "abcd" in second file.
By: Brian West (bkw918) 2003-12-10 12:06:19.000-0600

yes you need to allow W and maybe P also :)
By: Olle Johansson (oej) 2003-12-10 14:03:38.000-0600

small characters? For what? Haven't got any W or P buttons on my phone, that's why I ask - there's always something to learn :-)
By: Brian West (bkw918) 2003-12-10 14:05:37.000-0600

W is for pause/wait and is valid in a dialstring.  I recall seeing something about P being reserved.
By: Olle Johansson (oej) 2003-12-10 14:07:33.000-0600

Checked the RFC, 2833:
-------------------------------------------------------------------------
3.10 DTMF Events

  Table 1 summarizes the DTMF-related named events within the
  telephone-event payload format.

                    Event  encoding (decimal)
                    _________________________
                    0--9                0--9
                    *                     10
                    #                     11
                    A--D              12--15
                    Flash                 16

-------------------------------------------------------------------------
After that, there's a lot of different codes...
By: zoa (zoa) 2004-01-10 22:00:14.000-0600

can somebody add all valid ones ?
By: Olle Johansson (oej) 2004-01-11 03:00:39.000-0600

"Valid" depends on channel and standard. Can't find W and P anywhere as DTMF tones, A-D is definitely there. Seems manufacturers are adding freely themselves as well.

Could you please find a definitive "valid" list?
By: Olle Johansson (oej) 2004-03-21 10:24:17.000-0600

Reminder sent to oej

check this and fix it!
By: Brian West (bkw918) 2004-03-21 10:30:13.000-0600

wonder if senddtmf should be smart?  So I can dial 1900-HOT-CHAT and it coverts text to the dtmf equiv?
By: Brian West (bkw918) 2004-03-23 22:51:51.000-0600

added to cvs-head
By: Digium Subversion (svnbot) 2008-01-15 14:48:44.000-0600

Repository: asterisk
Revision: 2543

U   trunk/apps/app_senddtmf.c

------------------------------------------------------------------------
r2543 | jeremy | 2008-01-15 14:48:44 -0600 (Tue, 15 Jan 2008) | 2 lines

check input for errors. Bug ASTERISK-432

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=2543