Summary:ASTERISK-00270: [patch] Be better about finding mpg123
Reporter:Thorsten Lockert (tholo)Labels:
Date Opened:2003-09-14 12:22:41Date Closed:2004-09-25 02:46:18
Versions:Frequency of
Environment:Attachments:( 0) mp3.diff
( 1) mp3v2.diff
Description:Most systems, when mpg123 is installed, will have it in /usr/local/bin, while Asterisk expects it in /usr/bin


The enclosed diff will make Asterisk first check for it in /usr/local/bin, then in /usr/bin, and as a last ditch effort, look for it in PATH.
Comments:By: Brian West (bkw918) 2003-09-14 12:37:43

+#define LOCAL_MPG_123 "/usr/bin/mpg123"

in res_musiconhold.c

Shouldn't that be /usr/local/bin/mpg123 ??


By: Mark Spencer (markster) 2003-09-16 14:52:43

This will have to be updated for your other patch, can you do that and give me an update?

By: Thorsten Lockert (tholo) 2003-09-17 20:31:35

I put up a new version of the patch with the fix pointed out by Brian.

By: Thorsten Lockert (tholo) 2003-09-17 20:35:14

I'm at a bit of a loss as to why jtodd moved this one to Portability/FreeBSD as this was done to work better on a RedHat system.  And if it was for *BSD portability, I use OpenBSD for that... ;-)

By: John Todd (jtodd) 2003-09-18 00:07:12

Hmm... actually, I didn't move it to "FreeBSD" - that category appeared mysteriously after I moved it.  I just moved it to "Portability".  :-)

By: oliver (oliver) 2003-09-21 17:11:27


It seems like the part of the patch for "res/res_musiconhold.c" was added to CVS some days ago, but the one for "apps/app_mp3.c" still isn't.  Is there a specific reason for this?

By: Mark Spencer (markster) 2003-09-26 19:29:00

Fixed in CVS