[Home]

Summary:ASTERISK-00254: chan skinny makes asterisk exit if it can't find skinny.conf
Reporter:critch (critch)Labels:
Date Opened:2003-09-11 22:35:55Date Closed:2011-06-07 14:10:49
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:chan_skinny causes asterisk to fail to start if it can't find skinny.conf. For those doing cvs upgrades, we don't get the skinny.conf installed for us and is a surprise when asterisk fails to restart. Considered minor, but chan_skinny should just not do anything if it doesn't find it's config file and let asterisk continue to load.
Comments:By: John Todd (jtodd) 2003-09-11 23:47:52

I see Mark made these changes:

Update of /usr/cvsroot/asterisk/channels
In directory mongoose.digium.com:/tmp/cvs-serv30284/channels

Modified Files:
chan_skinny.c
Log Message:
Don't die if no config file


Index: chan_skinny.c
===================================================================
RCS file: /usr/cvsroot/asterisk/channels/chan_skinny.c,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- chan_skinny.c 11 Sep 2003 19:44:13 -0000 1.1
+++ chan_skinny.c 12 Sep 2003 03:21:14 -0000 1.2
@@ -2386,14 +2386,14 @@

if (gethostname(ourhost, sizeof(ourhost))) {
ast_log(LOG_WARNING, "Unable to get hostname, Skinny disabled\n");
- return 1;
+ return 0;
}
cfg = ast_load(config);

/* We *must* have a config file otherwise stop immediately */
if (!cfg) {
ast_log(LOG_NOTICE, "Unable to load config %s, Skinny disabled\n", config);
- return 1;
+ return 0;
}

/* load the general section */
By: John Todd (jtodd) 2003-09-11 23:48:30

Steven: I suppose if you could verify that it's fixed, this could be resolved/closed.
By: Brian West (bkw918) 2003-09-11 23:56:44

JerJer added this to CVS.. I see it in the changelog.

bkw
By: John Todd (jtodd) 2003-09-12 17:58:34

Seems to be fixed.  Unless someone says otherwise, this will close shortly.