[Home]

Summary:ASTERISK-00244: [patch] compile warning removal in app_queue.c
Reporter:Adam Goryachev (adamg)Labels:
Date Opened:2003-09-11 08:30:49Date Closed:2008-01-15 14:35:07.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Simple patch to app_queue to remove the parameter type mis-match.
               } else
                       ast_cli(fd, "   No Members\n");
               if (q->head) {
                       pos = 1;
                       ast_cli(fd, "   Callers: \n");
                       for (qe = q->head; qe; qe = qe->next)
                               ast_cli(fd, "      %d. %s (wait: %ld:%2.2ld)\n", pos++, qe->chan->name,
                                                               (now - qe->start) / 60, (now - qe->start) % 60);
               } else
                       ast_cli(fd, "   No Callers\n");
               ast_cli(fd, "\n");
               ast_mutex_unlock(&q->lock);
               q = q->next;
       }
       return RESULT_SUCCESS;

Basically just changing the %d to %ld when displaying the min:secs the call has been in the queue...
Comments:By: John Todd (jtodd) 2003-09-11 14:23:15

To make this simpler in the future, can you please post unified diff's (diff -u oldfile.c newfile.c) so it's immediately obvious where the adds/deletes need to be placed.  Of course, this is a very simple error, but when it's more than one line life gets very difficult when looking at web-wrapped code...
By: Adam Goryachev (adamg) 2003-09-11 19:42:12

yeah, I know, but it was way late at night, and I just wanted to get it into the bugs DB quickly before going to sleep...

Also by this stage I didn't have a clean copy of the file to run diff against anyway....
By: Brian West (bkw918) 2003-09-11 21:43:03

mv apps/app_queue.c apps/app_queue.c.new
make update
diff -u apps/app_queue.c apps/app_queue.c.new > app_queue.c.diff
By: Mark Spencer (markster) 2003-09-26 21:23:46

Fixed in CVS
By: Digium Subversion (svnbot) 2008-01-15 14:35:07.000-0600

Repository: asterisk
Revision: 1563

U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r1563 | markster | 2008-01-15 14:35:06 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix printf to match int type (bug ASTERISK-244)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=1563