Summary:ASTERISK-00094: [patch] Outgoing Limit (similar to h.323 outgoinglimit)
Reporter:patrick (patrick)Labels:
Date Opened:2003-08-13 06:24:30Date Closed:2011-06-07 14:05:28
Versions:Frequency of
Environment:Attachments:( 0) outgoinglimit.patch
( 1) outgoinglimit2.patch
( 2) patch.outgoinglimit.aa
Description:Patch provides ability to limit outgoing calls from a UA.
Keyword in sip.conf
outgoinglimit=0     ;  0 = unlimited
                   ;  any other positive number limits
                   ;  voice channels to that number
Comments:By: John Todd (jtodd) 2003-09-04 03:05:02

Patrick - did you get a disclaimer to Digium for this?  Since it's such a simple patch, I'll assume that there's some other holdup with adding it... Looks very useful, I'd like to see it added.

By: patrick (patrick) 2003-09-04 05:17:01

I already had one when I sent in the incominglimit patch.  Is one needed for every patch submitted?

By: John Todd (jtodd) 2003-09-04 11:16:47

No, you should be fine.  Sorry if I confused you.  Upon more examination, I see this isn't such a simple patch, which may be the reason it's taking a while to implement.  But who knows?  :-)

By: John Todd (jtodd) 2003-09-04 14:32:41

No, since this is a patch for SIP.  Note that it only says "similiar to H.323".

By: patrick (patrick) 2003-09-04 15:24:42

I submitted right before the changes for debugging threads, so it won't patch now.  
I can work on the patch for the latest chan_sip.c.   I still have to finish the modification to sip.conf.sample also.

By: John Todd (jtodd) 2003-09-04 15:38:12

Please do.  This is a very useful patch, and I'd like to see it added to the main CVS tree.

By: Brian West (bkw918) 2003-09-04 17:02:05

ah killer.. this will come in handy then.. mybad! :P

By: patrick (patrick) 2003-09-04 21:03:52

There, that should patch chan_sip.c
A brief synopsis of what was changed:
 Added the keyword "outgoinglimit" to sip.conf for each UA.
 Changed the function find_user() to use a switch/case structure instead of if/then
 Added #defines for int event instead of using 0,1,2,3
    #define DEC_IN_USE   0
    #define INC_IN_USE   1
    #define DEC_OUT_USE  2
    #define INC_OUT_USE  3

By: patrick (patrick) 2003-09-04 21:06:47

The viewpoint for understanding what incoming/outgoing defines is based from Asterisk:
  Incoming from SIP UA to Asterisk.
  Outgoing to SIP UA from Asterisk.

I had a couple of people ask which direction incoming was so I thought I might mention that here if anyone is interested.

By: patrick (patrick) 2003-09-05 10:49:20

Had to modify patch because another patch was added before this patch was applied.

By: Mark Spencer (markster) 2003-09-13 15:26:02

Merged in CVS

By: John Todd (jtodd) 2003-09-29 03:00:50

Does not seem to work as desired - see http://bugs.digium.com/bug_view_page.php?bug_id=0000329

By: ewieling (ewieling) 2003-10-06 12:29:00

It would be useful to have a "totallimit=" option which would limit tht total number of incoming + outgoing calls.

By: Digium Subversion (svnbot) 2008-01-15 14:34:19.000-0600

Repository: asterisk
Revision: 1505

U   trunk/channels/chan_sip.c

r1505 | markster | 2008-01-15 14:34:18 -0600 (Tue, 15 Jan 2008) | 2 lines

Outgoing limit updates (bug ASTERISK-94)