[Home]

Summary:ASTERISK-00091: X-Lite DTMF irregularities in rtp.c/channel.c
Reporter:km (km)Labels:
Date Opened:2003-08-12 22:27:10Date Closed:2008-01-15 14:31:55.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) rtp.c.diff
( 1) rtp.c.diff2
Description:It appears as if X-Lite is sending the correct DTMF digits, since process_rfc2833 shows the digits correctly (see below).  However, ast_waitfordigit does not seem to detect the digits at the right time, instead it flushes out the last digit it received when it receives the second digit.  I.e., if you sent "12345" via dtmf pad, asterisk would read "1234", but the 1 would only be registered when you pressed 2 on the DTMF pad.

This bug makes it impossible to check voicemail via x-lite.  I'm surprised more people haven't whined about it before?

****** ADDITIONAL INFORMATION ******

Event: 00000005 (len = 4)
Event: 00000009 (len = 4)
Event: 00000004 (len = 4)
Event: 00000006 (len = 4)
Event: 00000002 (len = 4)
   -- Playing 'vm-password'
Event: 00000001 (len = 4)
Event: 00000002 (len = 4)
Event: 00000003 (len = 4)
Event: 00000004 (len = 4)
   -- Incorrect password '2123' for user '5946' (context = <any>)
Comments:By: km (km) 2003-08-12 22:28:38

This problem may have something to do also with the double digit recognition issue that already existed with x-lite and asterisk.  Rob from xten has told me that they fixed the duration flag in the rtp packet so that shouldn't be the problem anymore.

By: cheiser (cheiser) 2003-08-14 12:10:43

rtp.c.diff should resolve this issue.

process_rfc2833 should now detect repeating DTMF digits as well as the "End" bit.

By: cheiser (cheiser) 2003-08-14 13:49:13

Do not use rtp.c.diff
Use rtp.c.diff2

rtp.c.diff has a small bug that will appear in high packet loss situations

By: Mark Spencer (markster) 2003-08-14 15:20:34

I need a disclaimer from the original author to apply the patch.

By: Mark Spencer (markster) 2003-08-14 16:49:12

Applied

By: Digium Subversion (svnbot) 2008-01-15 14:31:55.000-0600

Repository: asterisk
Revision: 1336

U   trunk/rtp.c

------------------------------------------------------------------------
r1336 | markster | 2008-01-15 14:31:55 -0600 (Tue, 15 Jan 2008) | 2 lines

Merge DTMF fixes (bug ASTERISK-91)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=1336