Summary:ASTERISK-00069: Festival eats DTMF
Reporter:jayson (jayson)Labels:
Date Opened:2003-08-08 15:50:37Date Closed:2008-01-15 14:31:57.000-0600
Versions:Frequency of
Environment:Attachments:( 0) 02-app_festival-gork_1.0.diff.txt
Description:I currently need to use app_festival for some menus.  It is not well suited to this because it eats DTMF tones (which do stop it) without allowing them to fall through to trigger the menu.  It would be nice to have some sort of option to function less like Playback and more like Background.
Comments:By: Brian West (bkw918) 2003-08-09 12:31:23

Does your app_festival speak faster than it should?

Check bugnote http://bugs.digium.com/bug_view_page.php?bug_id=0000067

I would like to know just for sanity sake!

By: jayson (jayson) 2003-08-09 17:07:39

No.  It has never done this, in fact.

By: Brian West (bkw918) 2003-08-09 17:28:28

Are you using the latest zaptel cvs?

By: jayson (jayson) 2003-08-10 17:56:53

Well, it was latest as of a few days ago.

Monday, I'll rebuild and find out.

I'll tar it up.  In the event it doesn't work, I can run a "cvs diff" on any files you need to see what's changed.

Where do I check to see what date I checked this out of CVS?

By: jayson (jayson) 2003-08-12 10:02:32

Rebuilt.  Newest CVS.

festival -v returns:

festival: Festival Speech Synthesis System: 1.4.2:release July 2001

No problems with speed.  Running with Tormenta 2 Quad T1/PRI Card (T400P?)

Hope that helps.

By: John Laur (gork) 2003-08-12 15:02:02

I have a patch for this. It adds a new command called FestivalBG that accepts DTMF and returns the digit as "Background" does. It changes the current behavior of "Festival" to work more like "Playback" in that it cannot be interrupted.

Patch is located here and I would be happy to have it included in standard CVS [I have filed a disclaimer]: http://www.blurbco.com/~gork/asterisk/02-app_festival-gork_1.0.diff

Note, there is another issue with Festival that is unrelated to the speaking fast problem and the DTMF problem that will result in a call getting dumped if very many calls are utalizing app_festival at once. I have not tested this in a couple months w/ CVS, but I will re-test soon with current code and see if it is still happening, and file another bug report if so.

By: jayson (jayson) 2003-08-14 13:19:52

Seconded here.

I've tried this and find it rock solid and darn useful.

Please merge.  Diff attached.

By: Mark Spencer (markster) 2003-08-14 23:29:49

Implemented, but not with this particular patch, just making the arguments work as they are listed.

By: jayson (jayson) 2003-08-15 13:23:38

That patch doesn't really fix the problem.

With the currently patched Festival, this:


Does not do the same as the other patch with:


In a perfect world, Festival needs to be able to be used interchangably with Playback / BackGround.  Right now, I can't do that.  Is there something about the gork patch you don't like?  Perhaps I can fix it?

By: John Laur (gork) 2003-08-15 13:31:39

Well my patch changes a documented behavior and that is potentailly a bad thing. However, since the documented behavior was broken for a very long time (maybe never really worked right to begin with) I didn't see that it would really be a problem as "Festival" will continue to not support DTMF and FestivalBG would.

My intent was to give some commands to help AGI writers and extensions.conf writers to do quick testing wihtout having to record voice prompts, then when the system is finalized, they could easily replace them with "Playback" and "Background" commands on a 1:1 basis.

By: Mark Spencer (markster) 2003-08-15 16:50:45

Return value was being ignored.  Fixed in CVS.

By: Digium Subversion (svnbot) 2008-01-15 14:31:57.000-0600

Repository: asterisk
Revision: 1338

U   trunk/apps/app_agi.c
U   trunk/apps/app_enumlookup.c
U   trunk/apps/app_festival.c
U   trunk/apps/app_queue.c
U   trunk/apps/app_voicemail2.c
U   trunk/channels/chan_sip.c
U   trunk/channels/chan_zap.c
U   trunk/codecs/ilbc/FrameClassify.c
U   trunk/codecs/ilbc/LPCdecode.c
U   trunk/codecs/ilbc/LPCencode.c
U   trunk/codecs/ilbc/StateConstructW.c
U   trunk/codecs/ilbc/StateSearchW.c
U   trunk/codecs/ilbc/anaFilter.c
U   trunk/codecs/ilbc/createCB.c
U   trunk/codecs/ilbc/doCPLC.c
U   trunk/codecs/ilbc/enhancer.c
U   trunk/codecs/ilbc/filter.c
U   trunk/codecs/ilbc/gainquant.c
U   trunk/codecs/ilbc/getCBvec.c
U   trunk/codecs/ilbc/helpfun.c
U   trunk/codecs/ilbc/hpInput.c
U   trunk/codecs/ilbc/hpOutput.c
U   trunk/codecs/ilbc/iCBConstruct.c
U   trunk/codecs/ilbc/iCBSearch.c
U   trunk/codecs/ilbc/iLBC_decode.c
U   trunk/codecs/ilbc/iLBC_encode.c
U   trunk/codecs/ilbc/lsf.c
U   trunk/codecs/ilbc/packing.c
U   trunk/codecs/ilbc/syntFilter.c
U   trunk/pbx/pbx_gtkconsole.c

r1338 | markster | 2008-01-15 14:31:57 -0600 (Tue, 15 Jan 2008) | 8 lines

ASTERISK-68 - Should eliminate probs on VMWI
ASTERISK-37 - Dynamic add survives reload
ASTERISK-69 - Make festival honor its arguments
ASTERISK-89 - Make events on FXO interfaces more logical
ASTERISK-22 - Prefer "bindaddr" to logical address for registrations
??? - Record crashes AGI