Summary:ASTERISK-00062: [patch] code fix-ups and clean-ups
Reporter:reptiles (reptiles)Labels:
Date Opened:2003-08-08 00:13:13Date Closed:2011-06-07 14:10:05
Versions:Frequency of
Environment:Attachments:( 0) codefix.patch
Description:these patches eliminate all the compiler warnings.
some patches re-arrange structures.
some patches update/correct function prototypes.


these patches should not alter the functionality of the built code.
making the code compile warning free is necessary for porting to other Unix flavours.
Comments:By: John Todd (jtodd) 2003-09-08 21:43:23

Jim - can you check to see if these are still valid against the current CVS?  There has been some good momentum (or at least griping) in the last 24 hours to get some additional platform support for Asterisk, and it seems like now might be the time when these patches get the attention they deserve for finding their way into the CVS tree.  If you can make sure they work, I'll see what I can do to move them a bit up the priority tree for getting added - I'm good at pestering, and I really want to see *BSD support...  ;-)

By: John Todd (jtodd) 2003-09-13 15:14:54

Just like the other two patches, this also messes with lpc10, so I supose I will test too...

By: John Todd (jtodd) 2003-09-18 13:21:53

Works with lpc10, ilbc, speex, and others.  This seems to have some overlapping functionality with http://bugs.digium.com/bug_view_page.php?bug_id=0000271 - the two patchsets are different and will step on each other's toes.  Compiles cleanly and works on a Asterisk CVS-09/18/03-15:32:29 checkout.

By: Mark Spencer (markster) 2003-09-18 20:19:16

Fixed in CVS.

By: John Todd (jtodd) 2003-09-26 17:01:20

Seems to be some problems with ilbc that are referenced in http://bugs.digium.com/bug_view_page.php?bug_id=0000309

Looks like just that section of code in .../ilbc/iCBSearch.c  is causing the problems.

By: John Todd (jtodd) 2003-09-29 03:40:15

It appears that these changes were made to CVS on Friday.  Is that true?  Should I move this back to "closed"?

By: John Todd (jtodd) 2003-10-19 20:30:21

No comments since 9-29, so I will perhaps falsely assume these have been added to CVS, and mark this as "closed".

By: Digium Subversion (svnbot) 2008-01-15 14:34:41.000-0600

Repository: asterisk
Revision: 1531

U   trunk/ast_expr.y
U   trunk/astman/astman.c
U   trunk/codecs/gsm/Makefile
U   trunk/codecs/ilbc/iCBSearch.c
U   trunk/codecs/lpc10/analys.c
U   trunk/codecs/lpc10/decode.c
U   trunk/codecs/lpc10/ivfilt.c
U   trunk/codecs/lpc10/placea.c
U   trunk/codecs/mp3/include/mhead.h
U   trunk/codecs/mp3/src/cupL1.c
U   trunk/codecs/mp3/src/cupini.c
U   trunk/codecs/mp3/src/cupl3.c
U   trunk/codecs/mp3/src/icdct.c
U   trunk/codecs/mp3/src/isbt.c
U   trunk/codecs/mp3/src/iup.c
U   trunk/codecs/mp3/src/iupini.c
U   trunk/codecs/mp3/src/iwinm.c
U   trunk/codecs/mp3/src/l3init.c
U   trunk/codecs/mp3/src/mdct.c
U   trunk/db1-ast/hash/hash_func.c
U   trunk/editline/histedit.h
U   trunk/utils/astman.c

r1531 | markster | 2008-01-15 14:34:40 -0600 (Tue, 15 Jan 2008) | 2 lines

Code cleanups (bug ASTERISK-62)