Summary:ASTERISK-00061: [patch] fix un-initialized variables
Reporter:reptiles (reptiles)Labels:
Date Opened:2003-08-08 00:10:07Date Closed:2011-06-07 14:10:41
Versions:Frequency of
Environment:Attachments:( 0) uninit-var.patch
Description:un-initialized variables can cause difficult to trace bugs.
while the code may not in fact use the variable un-initialized, a future coder could change the logic and leave it open to seg fault.


these changes should not negatively impact the code.
best case, they will cause the system to seg fault in a predictable fashion.  8^)
test compiled/verified on RH9
Comments:By: John Todd (jtodd) 2003-09-08 21:44:21

Same notes as those on 66.  Let's see if we can get these implemented if they're good against the CVS of today.

By: John Todd (jtodd) 2003-09-13 15:12:00

jtodd will put on his superhero patch cape and test this one too.

By: John Todd (jtodd) 2003-09-18 13:25:11

No longer cleanly patches on a fresh checkout of CVS.  Jim, if you can please twiddle this to work, I will test and verify on some other systems that this is OK.  I don't have the opportunity right now to alter the patch myself.

patch -p0 < /tmp/65.patch
patching file apps/app_agi.c
Hunk #1 FAILED at 452.
1 out of 1 hunk FAILED -- saving rejects to file apps/app_agi.c.rej
patching file apps/app_festival.c
Hunk #1 FAILED at 282.
1 out of 1 hunk FAILED -- saving rejects to file apps/app_festival.c.rej
patching file apps/app_macro.c
Hunk #1 FAILED at 59.
1 out of 1 hunk FAILED -- saving rejects to file apps/app_macro.c.rej
patching file apps/app_record.c
patching file apps/app_voicemail.c
patching file codecs/lpc10/pitsyn.c
patching file codecs/lpc10/voicin.c
patching file db1-ast/btree/bt_delete.c
patching file db1-ast/btree/bt_put.c
patching file db1-ast/btree/bt_seq.c
patching file db1-ast/btree/bt_split.c
patching file db1-ast/hash/hash_buf.c
patching file db1-ast/hash/hash_page.c
patching file db1-ast/recno/rec_open.c
patching file formats/format_g729.c
Hunk #1 FAILED at 168.
1 out of 1 hunk FAILED -- saving rejects to file formats/format_g729.c.rej
patching file formats/format_pcm.c
Hunk #1 FAILED at 158.
1 out of 1 hunk FAILED -- saving rejects to file formats/format_pcm.c.rej
patching file formats/format_pcm_alaw.c
Hunk #1 FAILED at 237.
1 out of 1 hunk FAILED -- saving rejects to file formats/format_pcm_alaw.c.rej
[root@ms1 asterisk]#

By: John Todd (jtodd) 2003-09-29 03:41:42

These patches may have been already applied in slightly different forms - can the author please check and let us know if there are duplications of effort here?

By: John Todd (jtodd) 2003-10-19 20:40:05

ping.  I'll test these and hopefully talk with mark to see if they can be applied to current CVS.

By: John Todd (jtodd) 2003-10-21 23:00:46

Probably duplicate to patches that already exist.  No comments?