Summary:ASTERISK-00060: [patch] comment out unused variables
Reporter:reptiles (reptiles)Labels:
Date Opened:2003-08-08 00:05:31Date Closed:2004-09-25 02:46:18
Versions:Frequency of
Environment:Attachments:( 0) unused-var.patch
Description:unused variables can lead to bugs because coders may not
realize the temporary nature of the variable and use it for
different purposes.


these patches should not change the function of the built binaries.
compile tested/verified on RH9
Comments:By: Mark Spencer (markster) 2003-08-09 14:19:33

the last_port will be used when we ditch IAX in favor of IAX2 permenantly.  Have you confirmed interoperability with LPC10 between the version w/ and without the variables?

I once tried to clean up LPC10 and it broke entirely for reasons that I cannot explain.  Before I'll touch it, I need someone to actually test interop between modified and unmodified code.

By: John Todd (jtodd) 2003-09-08 21:57:19

Same notes as the other patches by reptiles - let's see if it works with current CVS, and get it in there.  I'll do the pestering.

By: John Todd (jtodd) 2003-09-13 15:08:05

I suppose I will test the patches, then.  :|

By: John Todd (jtodd) 2003-09-18 13:27:45

No longer quite patches cleanly.  I don't have an opportunity right now to fix the patches.  Can you repair and re-submit, and I'll test sometime in the next few days before things change out from under you again.  :-)

[root@ms1 asterisk]# patch -p0 < /tmp/64.patch
patching file channels/chan_iax2.c
Hunk #1 FAILED at 3528.
Hunk #2 FAILED at 5052.
2 out of 2 hunks FAILED -- saving rejects to file channels/chan_iax2.c.rej
patching file codecs/gsm/src/decode.c
patching file codecs/gsm/src/long_term.c
patching file codecs/gsm/src/lpc.c
patching file codecs/gsm/src/preprocess.c
patching file codecs/gsm/src/rpe.c
patching file codecs/gsm/src/short_term.c
patching file formats/format_mp3.c
Hunk #1 FAILED at 42.
1 out of 1 hunk FAILED -- saving rejects to file formats/format_mp3.c.rej
patching file res/res_musiconhold.c
Hunk #1 FAILED at 477.
1 out of 1 hunk FAILED -- saving rejects to file res/res_musiconhold.c.rej
[root@ms1 asterisk]#

By: Mark Spencer (markster) 2003-09-26 21:24:27

Fixed by other patches