| Summary: | ASTERISK-00058: moh for an agents on a ZAP channel uses the musiconhold from zapata.conf NOT the musiconhold from agent.conf | ||
| Reporter: | tclark (tclark) | Labels: | |
| Date Opened: | 2003-08-07 17:56:06 | Date Closed: | 2008-01-15 14:31:52.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_queue |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | revision 1.25 of chan_agent.c if using an agent on a zap channel & in the agent.conf file you set musiconhold class the class is over ridden by the musiconhold class defined in the zapata.conf file. ****** ADDITIONAL INFORMATION ****** line 995 in chan_agent.c is the problem .. /* check if the moh class was changed with setmusiconhold */ if (*(chan->musicclass)) strncpy(p->moh, chan->musicclass, sizeof(p->moh) - 1); this musicclass is set by zt_new in chan_zap not by some ext logic using setmusiconhold It would appear the ast chan struct needs a flag to say HOW the musicclass is set so that an over ride for an agent using setmusiconhold can over ride an agent.conf musiconhold BUT a musiconhold setting from zapata.conf should NOT over ride a musiconhold | ||
| Comments: | By: Mark Spencer (markster) 2003-08-14 15:58:33 Okay we ignore the music class unless #define'd. However, I'm not going to bother with how it's set. If you want different music, set it in agents.conf, otherwise just stick with what you have. By: Digium Subversion (svnbot) 2008-01-15 14:31:52.000-0600 Repository: asterisk Revision: 1332 U trunk/channels/chan_agent.c ------------------------------------------------------------------------ r1332 | markster | 2008-01-15 14:31:51 -0600 (Tue, 15 Jan 2008) | 2 lines ignore musicclass for music on hold (bug ASTERISK-58) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=1332 | ||